Skip to content

Only perform parallel ir generation if -num-threads > 1 #32208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Only perform parallel ir generation if -num-threads > 1 #32208

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions include/swift/AST/SILOptions.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,9 +188,7 @@ class SILOptions {
return OptMode > OptimizationMode::NoOptimization;
}

bool hasMultipleIRGenThreads() const { return NumThreads > 1; }
bool shouldPerformIRGenerationInParallel() const { return NumThreads != 0; }
bool hasMultipleIGMs() const { return hasMultipleIRGenThreads(); }
bool shouldPerformIRGenerationInParallel() const { return NumThreads > 1; }
};

} // end namespace swift
Expand Down
2 changes: 1 addition & 1 deletion lib/Frontend/CompilerInvocation.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1204,7 +1204,7 @@ static bool ParseTBDGenArgs(TBDGenOptions &Opts, ArgList &Args,
CompilerInvocation &Invocation) {
using namespace options;

Opts.HasMultipleIGMs = Invocation.getSILOptions().hasMultipleIGMs();
Opts.HasMultipleIGMs = Invocation.getSILOptions().shouldPerformIRGenerationInParallel();

if (const Arg *A = Args.getLastArg(OPT_module_link_name)) {
Opts.ModuleLinkName = A->getValue();
Expand Down