[5.3][CodeCompletion] Wrap base expression with CodeCompletionExpr #32207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please Build Toolchain macOS Platform |
|
@swift-ci Please test |
|
macOS Toolchain Install command |
For example for: funcName(base.<HERE>) Wrap 'base' with 'CodeCompletionExpr' so that type checker can check 'base' independently without preventing the overload choice of 'funcName'. This increases the chance of successful type checking. rdar://problem/63965160 (cherry picked from commit 3ec250f)
rintaro
force-pushed
the
5.3-ide-completion-rdar63965160
branch
from
76f75ce to
b9ad518
Compare
|
@swift-ci Please Build Toolchain macOS Platform |
|
@swift-ci Please test |
|
Build failed |
|
Build failed |
|
Testing again to ensure nothing is broken. |
|
Build failed |
|
@swift-ci Please test Linux |
|
@swift-ci Please nominate |
tkremenek
approved these changes
Jun 11, 2020
AnthonyLatsis
added
swift 5.3
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #32184 into
release/5.3CodeCompletionExpr(e.g.funcName(base.<HERE>)) so that the base expression can be type checked independently while the surrounding expression can be type checked with a "hole" type variable. This increases the chance of successful type checking, and improves overall completion quality of member completion