[stdlib][test] Fix message test expectation. #32199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In swiftlang#32137 direct environment variable parsing was introduced, the availability of which is branched by a preprocessor symbol (`ENVIRON`) if the environment is available directly on the platform, or if getenv must be used. The message expectation in the unit test in the however diverged on the non-`ENVIRON` branch, causing a unit test failure. This PR fixes the expectation, but also, while we're here, OpenBSD supports the `ENVIRON` branch anyway.
|
cc @mikeash |
|
Looks good, thank you! I must have failed to run the test on the |
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #32137 direct environment variable parsing was introduced, the
availability of which is branched by a preprocessor symbol (
ENVIRON)if the environment is available directly on the platform, or if getenv
must be used.
The message expectation in the unit test in the however diverged on the
non-
ENVIRONbranch, causing a unit test failure. This PR fixes theexpectation, but also, while we're here, OpenBSD supports the
ENVIRONbranch anyway.