build: use the same pattern for detecting Darwin platforms #32182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The host platform should be using `CMAKE_SYSTEM_NAME STREQUAL Darwin`. However, we currently drive the host side of the compilation against custom variables. This makes the migration simpler by ensuring that the entire file uses the same pattern. Since `is_darwin_based_sdk` is now used only in the standard library build, sink it to the standard library build.
|
@swift-ci please test |
|
CC: @drexin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The host platform should be using
CMAKE_SYSTEM_NAME STREQUAL Darwin.However, we currently drive the host side of the compilation against
custom variables. This makes the migration simpler by ensuring that the
entire file uses the same pattern.
Since
is_darwin_based_sdkis now used only in the standard librarybuild, sink it to the standard library build.
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.