Skip to content

Fix dependency scanner test-case to use explicit imports #32167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 4, 2020
Merged

Fix dependency scanner test-case to use explicit imports #32167

merged 1 commit into from
Jun 4, 2020

Conversation

@artemcm
Copy link
Contributor

@artemcm artemcm commented Jun 3, 2020

Fast dependency scanner cannot currently handle implicit imports. (rdar://problem/63944222)
In the meantime, make the tests use explicit imports.

@artemcm artemcm requested a review from nkcsgexi June 3, 2020 22:08
@artemcm
Copy link
Contributor Author

artemcm commented Jun 3, 2020

@swift-ci test

nkcsgexi
nkcsgexi approved these changes Jun 3, 2020
View reviewed changes
Copy link
Contributor

@nkcsgexi nkcsgexi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@nkcsgexi nkcsgexi merged commit d992e04 into swiftlang:master Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nkcsgexi nkcsgexi nkcsgexi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@artemcm @nkcsgexi