Skip to content

Conversation

@compnerd
Copy link
Member

@compnerd compnerd commented Jun 3, 2020

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

@compnerd
Copy link
Member Author

compnerd commented Jun 3, 2020

@swift-ci please smoke test

@compnerd
Copy link
Member Author

compnerd commented Jun 3, 2020

CC: @aschwaighofer

@compnerd
Copy link
Member Author

compnerd commented Jun 3, 2020

@swift-ci please smoke test macOS platform

@aschwaighofer
Copy link
Contributor

I didn't know we had %target-abi. This is more reasonable then %target-os would have been.

@compnerd
Copy link
Member Author

compnerd commented Jun 3, 2020

@aschwaighofer yeah, we added that when I was originally doing all the ABI conversions to support Windows. Sounds good! Not sure if there is a better way to check the various different ABIs.

@compnerd compnerd merged commit 56c361a into swiftlang:master Jun 3, 2020
@compnerd compnerd deleted the 31986 branch June 3, 2020 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants