DependenciesScanner: propagate front-end arguments for disabling implicit Swift/Clang modules #32125
Conversation
nkcsgexi
force-pushed
the
add-flag-disable-swift-implicit
branch
from
a5af488 to
6bce33d
Compare
|
@swift-ci please smoke test |
There was a problem hiding this comment.
There seem to be enough flags here to probably warrant a ModuleInterfaceOptions type. That can be done in a follow-up.
nkcsgexi
force-pushed
the
add-flag-disable-swift-implicit
branch
from
6bce33d to
0f0782f
Compare
|
@swift-ci please smoke test |
nkcsgexi
force-pushed
the
add-flag-disable-swift-implicit
branch
from
0f0782f to
5142295
Compare
|
@swift-ci please smoke test |
nkcsgexi
force-pushed
the
add-flag-disable-swift-implicit
branch
from
4c6fbd1 to
03f5654
Compare
|
@swift-ci please smoke test |
|
@swift-ci please test |
|
Build failed |
|
Build failed |
|
@swift-ci Please smoke test Linux platform |
DougGregor
left a comment
DougGregor
left a comment
There was a problem hiding this comment.
Very cool! I had a couple of comments for improvements here, but nothing big.
There was a problem hiding this comment.
Can these go into SearchPathOptions along with the various search paths? They shouldn't affect the "language" per se.
There was a problem hiding this comment.
Yeah, I think SearchPathOptions probably is a more proper home for these paths.
There was a problem hiding this comment.
Why pass -disable-implicit-swift-modules here? The scanner effectively doesn't heed that flag, right?
There was a problem hiding this comment.
This is to teach the scanner to channel this flag to all the reported build commands. So that all interface build commands in the JSON file now have -disable-implicit-swift-modules.
There was a problem hiding this comment.
I think we've been trying to move toward "separate" flags nowadays, rather than joined flags with =.
|
@swift-ci please test |
|
Build failed |
|
Build failed |
nkcsgexi
force-pushed
the
add-flag-disable-swift-implicit
branch
from
423cd36 to
5193c94
Compare
|
@swift-ci please test |
|
Build failed |
|
Build failed |
|
@swift-ci please test |
|
Build failed |
|
@swift-ci please smoke test |
…ystem should specify it
…module from interface
nkcsgexi
force-pushed
the
add-flag-disable-swift-implicit
branch
from
5193c94 to
0d74428
Compare
|
@swift-ci please smoke test |
2 similar comments
|
@swift-ci please smoke test |
|
@swift-ci please smoke test |
|
@swift-ci Please smoke test OS X platform |
|
@swift-ci please test |
|
Build failed |
|
Build failed |
4 participants
The PR focuses on propagating several flags related to explicit module building:
For Clang modules, we need build system to pass down extra clang flags
-fno-implicit-modules,-fmodule-map-file=,-fmodule-file=to avoid building PCMs implicitly from the Swift compiler.New flags
-disable-implicit-swift-modulesto prevent and stop the compilers from building any Swift modules from interfaces implicitly and diagnose if they have to.rdar://62613306