Skip to content

Fix an edge case in ExistentialSpecializer #32123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 2, 2020
Merged

Fix an edge case in ExistentialSpecializer #32123

merged 1 commit into from
Jun 2, 2020

Conversation

@meg-gupta
Copy link
Contributor

@meg-gupta meg-gupta commented Jun 1, 2020

ExistentialSpecializer could be building the function type from a
witness_method. We cannot attach a witnessProtocolConformance to the
newly specialized thin function.

@meg-gupta
Copy link
Contributor Author

meg-gupta commented Jun 1, 2020

Encountered this when debugging a source compatibility suite assertion for #30710
Assertion failed: (WitnessMethodConformance.isInvalid() && "non-witness_method SIL function with a conformance"), function SILFunctionType, file ~/swift_source/swift/lib/AST/ASTContext.cpp, , line 3310

@meg-gupta meg-gupta requested a review from aschwaighofer June 1, 2020 17:55
@meg-gupta
Copy link
Contributor Author

meg-gupta commented Jun 1, 2020

@swift-ci test

@aschwaighofer
Copy link
Contributor

aschwaighofer commented Jun 1, 2020

Makes sense to me. Can you add a test case?

@swift-ci
Copy link
Contributor

swift-ci commented Jun 1, 2020

Build failed
Swift Test Linux Platform
Git Sha - 5ffd5dc577a8c5855ca7703609312a32f74ee457

@meg-gupta
Copy link
Contributor Author

meg-gupta commented Jun 2, 2020

@aschwaighofer Added test

@meg-gupta
Copy link
Contributor Author

meg-gupta commented Jun 2, 2020

@swift-ci test

@swift-ci
Copy link
Contributor

swift-ci commented Jun 2, 2020

Build failed
Swift Test OS X Platform
Git Sha - 5ffd5dc577a8c5855ca7703609312a32f74ee457

@swift-ci
Copy link
Contributor

swift-ci commented Jun 2, 2020

Build failed
Swift Test Linux Platform
Git Sha - 5ffd5dc577a8c5855ca7703609312a32f74ee457

@meg-gupta
Copy link
Contributor Author

meg-gupta commented Jun 2, 2020

@swift-ci test OS X

@meg-gupta
Fix an edge case in ExistentialSpecializer
4804616 
ExistentialSpecializer could be building the function type from a
witness_method. We cannot attach a witnessProtocolConformance to the
newly specialized thin function.
@meg-gupta
Copy link
Contributor Author

meg-gupta commented Jun 2, 2020

@swift-ci test

@swift-ci
Copy link
Contributor

swift-ci commented Jun 2, 2020

Build failed
Swift Test OS X Platform
Git Sha - b0a6c0ad3e4c91b41d2baf7698ffe0cd5b8fbe0f

@swift-ci
Copy link
Contributor

swift-ci commented Jun 2, 2020

Build failed
Swift Test Linux Platform
Git Sha - b0a6c0ad3e4c91b41d2baf7698ffe0cd5b8fbe0f

@meg-gupta
Copy link
Contributor Author

meg-gupta commented Jun 2, 2020

@swift-ci test OS X

@meg-gupta meg-gupta merged commit 47ef155 into swiftlang:master Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aschwaighofer aschwaighofer Awaiting requested review from aschwaighofer

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@meg-gupta @aschwaighofer @swift-ci