Fix comparisons between presumed and buffer line numbers #32020
Merged
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci please smoke test |
rintaro
approved these changes
May 26, 2020
Member
rintaro
left a comment
rintaro
left a comment
There was a problem hiding this comment.
Since the parser one is comparing columns (not line numbers), it shouldn't have been an issue. Nevertheless this is a good change. Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found these while auditing calls to the line-and-column source manager methods after they were renamed. In the first case, comparing presumed line numbers for equality is not desirable when deciding if we should emit parsing warnings. In the second case, a presumed line number was incorrectly compared to a buffer line number.