Skip to content

[IRGen] NFC: Clean up Alignment type #32018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 27, 2020
Merged

[IRGen] NFC: Clean up Alignment type #32018

merged 1 commit into from
May 27, 2020

Conversation

@davezarzycki
Copy link
Contributor

@davezarzycki davezarzycki commented May 26, 2020

  1. Shrink from 4 bytes to 1 byte.
  2. Assert that alignments are power-of-two at run time.
  3. Assert that alignments are power-of-two at compile time when possible.
  4. Eliminate "isZero"/"no alignment" from the type. Use llvm::Optional.

@davezarzycki
[IRGen] NFC: Clean up Alignment type
eab7cb7 
1) Shrink from 4 bytes to 1 byte.
2) Assert that alignments are power-of-two at run time.
3) Assert that alignments are power-of-two at compile time when possible.
4) Eliminate "isZero"/"no alignment" from the type. Use llvm::Optional.
@davezarzycki
Copy link
Contributor Author

davezarzycki commented May 26, 2020

@swift-ci please test

atrick
atrick approved these changes May 26, 2020
View reviewed changes
Copy link
Contributor

@atrick atrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

AnthonyLatsis
AnthonyLatsis reviewed May 26, 2020
View reviewed changes
@davezarzycki davezarzycki merged commit e05d4e9 into swiftlang:master May 27, 2020
@davezarzycki davezarzycki deleted the pr32018 branch May 27, 2020 09:27
@rjmccall
Copy link
Contributor

rjmccall commented May 27, 2020

I wonder if we should just move to llvm::Alignment now that it exists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AnthonyLatsis AnthonyLatsis AnthonyLatsis left review comments

@atrick atrick atrick approved these changes

@jckarter jckarter Awaiting requested review from jckarter

@rjmccall rjmccall Awaiting requested review from rjmccall

@adrian-prantl adrian-prantl Awaiting requested review from adrian-prantl

@eeckstein eeckstein Awaiting requested review from eeckstein

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@davezarzycki @rjmccall @atrick @AnthonyLatsis