[5.3] IRGen: Fix enumPayload value witness emission for huge types #31935
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LLVM's isel does not like integer types beyond a certain size (llvm::IntegerType::MAX_INT_BITS). Explanation: The compiler would crash in the LLVM backend on imported C types beyond a certain size. Scope: Causes Swift programs that use types imported from C > 512K to crash the compiler. Risk: Low. Only affects code generation of enum witnesses for very large types (512K). Testing: Unit test added. rdar://63189452
Contributor
Author
|
@swift-ci Please test |
tkremenek
approved these changes
May 21, 2020
AnthonyLatsis
added
swift 5.3
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LLVM's isel does not like integer types beyond a certain size
(llvm::IntegerType::MAX_INT_BITS).
Explanation: The compiler would crash in the LLVM backend on imported C types
beyond a certain size.
Scope: Causes Swift programs that use types imported from C > 512K to crash the
compiler.
Risk: Low. Only affects code generation of enum witnesses for very large types
(512K).
Testing: Unit test added.
Original PR: #31918
rdar://63189452