[SymbolGraph] Show get/set on property/subscript full declarations #31903
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitjammer
changed the title
Contributor
Author
|
@swift-ci Please smoke test |
jackhl
requested changes
May 20, 2020
jackhl
left a comment
jackhl
left a comment
There was a problem hiding this comment.
Can you add a test that a let stored property gets a {get} and a var stored property gets a {get set}?
But don't show them in subheading contexts. rdar://63233897
Contributor
Author
|
Stored properties don't show |
Contributor
Author
|
@swift-ci Please smoke test. |
Contributor
Author
|
Looks like an unrelated swift-driver failure. Will try again in a little while. |
Contributor
Author
|
@swift-ci Please smoke test |
Contributor
Author
|
Windows bot is out of space. |
Contributor
Author
|
@swift-ci Please test Windows platform |
1 similar comment
Contributor
Author
|
@swift-ci Please test Windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
But don't show them in subheading contexts.
rdar://63233897