[SR-12827] [Diagnostics] Improve diagnostics keypath hole involving generic argument #31848
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xedin
requested changes
May 18, 2020
LucianoPAlmeida
force-pushed
the
SR-12827-keypath-hole
branch
from
cdeadc8 to
f3f34d9
Compare
xedin
reviewed
May 20, 2020
xedin
reviewed
May 20, 2020
LucianoPAlmeida
force-pushed
the
SR-12827-keypath-hole
branch
6 times, most recently
from
e399a25 to
c61a8e1
Compare
xedin
requested changes
May 21, 2020
LucianoPAlmeida
force-pushed
the
SR-12827-keypath-hole
branch
from
c61a8e1 to
47509d3
Compare
LucianoPAlmeida
force-pushed
the
SR-12827-keypath-hole
branch
from
47509d3 to
1097dae
Compare
xedin
reviewed
May 21, 2020
…r being bound to hole has a key path root representatee
LucianoPAlmeida
force-pushed
the
SR-12827-keypath-hole
branch
from
1097dae to
3f51637
Compare
LucianoPAlmeida
force-pushed
the
SR-12827-keypath-hole
branch
from
3f51637 to
f7234a3
Compare
xedin
reviewed
May 21, 2020
…instead of inline in the header
Contributor
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve diagnostics involving key path root and generic arguments.
cc @xedin @hamishknight
Let me know what you think :)
Resolves SR-12827.