GSB: Concretize nested types when adding a superclass constraint #31835
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci Please smoke test |
Contributor
Author
|
@swift-ci Please test source compatibility |
slavapestov
force-pushed
the
gsb-superclass-nested-type
branch
from
efff09d to
3478f99
Compare
When adding a superclass constraint, we need to find any nested types belonging to protocols that the superclass conforms to, and introduce implicit same-type constraints between each nested type and the corresponding type witness in the superclass's conformance to that protocol. Fixes <rdar://problem/39481178>, <https://bugs.swift.org/browse/SR-11232>.
slavapestov
force-pushed
the
gsb-superclass-nested-type
branch
from
3478f99 to
514a042
Compare
Contributor
Author
|
@swift-ci Please smoke test |
Contributor
Author
|
@swift-ci Please test source compatibility |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding a superclass constraint, we need to find any nested
types belonging to protocols that the superclass conforms to,
and introduce implicit same-type constraints between each nested
type and the corresponding type witness in the superclass's
conformance to that protocol.
Fixes rdar://problem/39481178, https://bugs.swift.org/browse/SR-11232.