[NFC] AST: Define SubstitutionMap::getInnermostReplacementTypes #31812
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnthonyLatsis
force-pushed
the
substitution-revolution-pre-1
branch
from
47232d3 to
bf0e348
Compare
AnthonyLatsis
commented
May 15, 2020
include/swift/AST/Types.h
Outdated
Collaborator
Author
There was a problem hiding this comment.
I am not a fan of getInnermostGenericArgs though. "Direct" generic arguments and innermost generic arguments are not always the same thing.
AnthonyLatsis
force-pushed
the
substitution-revolution-pre-1
branch
from
bf0e348 to
eedb335
Compare
Collaborator
Author
|
@swift-ci please smoke test |
Collaborator
Author
|
@slavapestov ping |
slavapestov
approved these changes
Jun 19, 2020
Collaborator
Author
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for storing substitution maps in bound generic types, centralize the logic for retrieving the innermost generic arguments in a new method on
SubstitutionMap.I wasn't able to find any duplication to clean up, so right now the only client is
TypeAliasType::getInnermostGenericArgs. The idea is for the new method to ultimately have at least two clients, including a futureBoundGenericType::getInnermostGenericArgs.For #31895