AST: Don't set source location on cloned parameter lists #31778
Conversation
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
The test should ideally be positive. Is there a visible difference in a loc attachment on either a debug_value or an alloc_stack that we could check for?
There was a problem hiding this comment.
I didn't see one, in fact this test passes without my change, which is why I asked :) I'm not going to merge this in its current state.
There was a problem hiding this comment.
Do you perhaps see a difference with -verbose-sil? This also prints the non-debug-info relevant details of SILLocation.
slavapestov
force-pushed
the
cloned-parameter-list-source-loc
branch
from
bd96d04 to
ffd92f9
Compare
|
@swift-ci Please smoke test |
|
@swift-ci Please smoke test macOS |
|
@swift-ci Please smoke test Linux |
2 similar comments
|
@swift-ci Please smoke test Linux |
|
@swift-ci Please smoke test Linux |
|
@swift-ci Please clean smoke test Linux |
2 similar comments
|
@swift-ci Please clean smoke test Linux |
|
@swift-ci Please clean smoke test Linux |
|
This seems to have introduced a regression on the windows builds: https://ci-external.swift.org/job/oss-swift-windows-x86_64-vs2019/1538/changes#detail |
3 participants
Note that rdar://problem/63191951 was actually fixed by #31992, and not this change as I expected. However, this change makes sense anyway, and this PR adds the missing test case.