[CodeCompletion] Annotated type name and 'IsSystem' #31738
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'key.is_system: 1' is added if the associated declaration is from a system module. rdar://problem/62617558 (cherry picked from commit 75a0c9f)
Only check lines we really care about. (cherry picked from commit f80fdfc)
Introduced 'TypeAnnotationBegin' chunk kind for grouping the result type name chunks. rdar://problem/62617558 (cherry picked from commit 7086ffb)
(cherry picked from commit ecfd369)
(cherry picked from commit 7e170de)
Member
Author
|
@swift-ci Please test |
akyrtzi
approved these changes
May 12, 2020
Member
Author
|
@swift-ci Please nominate |
AnthonyLatsis
added
swift 5.3
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #31646 and #31637 into
release/5.3branchkey.is_systemflag to completion items if the associated symbol is declared in a system module. Enable XML annotation forkey.typenameproperty if annotation is enabled. Clients can use these information for syntax highlighting code completion results