Const-Qualify LangOptions and TypeCheckerOptions #31721
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci test |
harlanhaskins
approved these changes
May 12, 2020
Contributor
harlanhaskins
left a comment
harlanhaskins
left a comment
There was a problem hiding this comment.
Do we need to change the CMake to avoid passing this to SwiftOnoneSupport?
Contributor
Author
I'll get it in a follow-up. |
CodaFi
force-pushed
the
const-of-proportionality
branch
from
c153241 to
c1db4be
Compare
Contributor
Author
|
@swift-ci smoke test |
Contributor
Author
|
@swift-ci test Windows |
…bodies This allows us to push the validation and, importantly, the mutation of this flag into the compiler invocation where it belongs.
The constraint system will need this if it wants to disable debug mode for serialized modules
This eliminates the final source of mutation of the TypeCheckerFlags on the ASTContext.
CodaFi
force-pushed
the
const-of-proportionality
branch
from
c1db4be to
2bca013
Compare
Contributor
Author
|
@swift-ci smoke test |
Contributor
Author
|
@swift-ci clean smoke test Linux platform |
Contributor
Author
|
⛵ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This required moving aside the hacks that necessitated mutating these options outside of the frontend.
For LangOptions,
-experimental-skip-function-bodieswas silently disabling itself if the module under scrutiny wasSwiftOnoneSupport. Push this computation into the frontend and warn about it.For TypeCheckerOptions the main offender was the expression checker's debugging flags. For these, add a bit to
ConstraintSystemFlagsand convert the save-and-restore patterns to use that instead. A beneficial behavior where constraint debugging was turned off for loaded modules is being emulated by plumbing the notion of the "main module" intoModuleDeclitself.