[AutoDiff] Fix derivative function configurations for accessors. #31669
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For accessors: make `AbstractFunctionDecl::getDerivativeFunctionConfigurations` resolve configurations from parent storage declaration `@differentiable` attributes. Fixes "no `@differentiable` attribute" non-differentiability error for accessors whose parent storage declaration `@differentiable` attributes have not been type-checked (e.g. because the storage declarations are in another file). Add protocol requirement and class member storage declaration tests. Resolves TF-1234.
marcrasi
approved these changes
May 9, 2020
Contributor
Author
|
@swift-ci Please test |
rxwei
approved these changes
May 9, 2020
rxwei
pushed a commit
to rxwei/swift
that referenced
this pull request
Jun 3, 2020
…ftlang#31669) For accessors: make `AbstractFunctionDecl::getDerivativeFunctionConfigurations` resolve configurations from parent storage declaration `@differentiable` attributes. Fixes "no `@differentiable` attribute" non-differentiability error for accessors whose parent storage declaration `@differentiable` attributes have not been type-checked (e.g. because the storage declarations are in another file). Add protocol requirement and class member storage declaration tests. Resolves TF-1234.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For accessors: make
AbstractFunctionDecl::getDerivativeFunctionConfigurationsresolve configurations from parent storage declaration
@differentiableattributes.
Fixes "no
@differentiableattribute" non-differentiability error for accessorswhose parent storage declaration
@differentiableattributes have not beentype-checked (e.g. because the storage declarations are in another file).
Add protocol requirement and class member storage declaration tests.
Resolves TF-1234.