[build-script] On non-Darwin build lld by default. #31647
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will let us use lld to link the stdlib. This will allow us to avoid problems due to old compilers being used on certain older distributions that we support. If anyone wants to not build lld, they can just pass to build-script-impl --skip-build-lld
Contributor
Author
|
@swift-ci smoke test |
Contributor
Author
|
It is just good to have tools that are meant to work together when building target like things. |
Contributor
Author
|
@swift-ci smoke test linux platform |
compnerd
reviewed
May 8, 2020
Member
compnerd
left a comment
compnerd
left a comment
There was a problem hiding this comment.
Is there a reason to not just build it always? The lld build times are negligible.
Contributor
Author
|
@compnerd I just don't want to cross that bridge for now. This is unquestionably an improvement. |
shahmishal
approved these changes
May 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will let us use lld to link the stdlib. This will allow us to
avoid problems due to old compilers being used on certain older distributions
that we support.
If anyone wants to not build lld, they can just pass to build-script-impl
--skip-build-lld