build: convert out parameter to target #31612
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rework `_add_host_variant_c_compile_link_flags` to apply the flags directly rather than to compute the value and have the caller apply.
Member
Author
|
@swift-ci please clean test |
Member
Author
|
CC: @drexin |
edymtt
added a commit
to edymtt/swift
that referenced
this pull request
May 14, 2020
Following swiftlang#31125 and swiftlang#31612, `-target` is not added automatically to linker flags when that's needed (e.g. when building for Apple SDKs) -- mimic the logic used to add it for compiler flags. Addresses rdar://63138761
edymtt
added a commit
that referenced
this pull request
May 18, 2020
edymtt
added a commit
to edymtt/swift
that referenced
this pull request
Jul 2, 2020
Following the refactoring in swiftlang#31612, LTO flag was only added to compile flags -- we need to pass this only when linking. Addresses rdar://65037856
edymtt
added a commit
that referenced
this pull request
Jul 2, 2020
Following the refactoring in #31612, LTO flag was only added to compile flags -- we need to pass this only when linking. Addresses rdar://65037856
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rework
_add_host_variant_c_compile_link_flagsto apply the flagsdirectly rather than to compute the value and have the caller apply.
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.