Define ResolveTypeRequest #31458
Merged
Define ResolveTypeRequest #31458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci test |
Contributor
Author
|
@swift-ci test source compatibility |
|
|
||
| void swift::simple_display(llvm::raw_ostream &out, | ||
| const TypeResolution *resolution) { | ||
| out << "while resolving type "; |
Contributor
There was a problem hiding this comment.
Should this also print the type?
Contributor
Author
There was a problem hiding this comment.
This definition of simple_display is a layering violation. TypeResolution lives in libSema.
Contributor
Author
There was a problem hiding this comment.
Not much more I can do here, I'm afraid. I have no ability to access members.
Contributor
Author
There was a problem hiding this comment.
simple_display will fire on the adjacent typerepr, so this should render just fine.
Contributor
Author
|
⛵ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that the foundations are merged, requestify type resolution. I'll eventually use this to migrate all the callers of
TypeChecker::validateTypeonce their TypeLocs have been stripped.