[string] Add _deconstructUTF8 for internal usage #31239
Conversation
|
@swift-ci please test |
There was a problem hiding this comment.
@Catfish-Man this would be another place where we expect to not use the large nibble
There was a problem hiding this comment.
@Catfish-Man we'd like to exhaustively test different possibilities of tagged, large contiguous ASCII, and large UTF-16 NSStrings. Is this the best way and/or is this complete? Is there something more guaranteed?
There was a problem hiding this comment.
Check out setUpStringTests in ObjectiveCTests.m for every possibility I could remember
|
@swift-ci please test |
|
Build failed |
|
Build failed |
milseman
changed the title
|
@swift-ci please test |
|
Build failed |
|
Build failed |
There was a problem hiding this comment.
I think you can remove constant evaluable comment here, if you like. This is not required to be constant evaluable and possibly won't ever be.
Add string deconstruction into contiguous UTF-8 (allocating if needed). Comments and docs to come soon, for now doing early testing.
|
Just wondering. May be I missed it, does this PR have a public API (not meant for testing) that is meant for the os_swiftoverlay? |
|
@swift-ci please test |
Right now it has one that's flagged plain public. I'm thinking about whether we want to restrict it to SPI os_swiftoverlay if we also want it to be a compiler intrinsic. |
|
Build failed |
|
Build failed |
4 participants
Add string deconstruction into contiguous UTF-8 (allocating if
needed).
rdar://problem/59329461