[AutoDiff upstream] add more validation tests #31112
Conversation
|
@swift-ci please test |
|
Build failed |
|
Build failed |
|
Oh no, there is an |
|
@swift-ci please test |
|
Build failed |
|
Build failed |
|
@swift-ci please test |
|
@swift-ci please test windows |
| } | ||
|
|
||
| // TODO(SR-8699): Fix this test. | ||
| // MethodTests.testWithLeakChecking( |
There was a problem hiding this comment.
I believe StdlibUnitTest has a nice built-in way of XFAILing tests. Does this not consistently fail/pass/crash?
| } | ||
|
|
||
| // TODO(SR-8699): Fix this test. | ||
| // MethodTests.testWithLeakChecking("static method with custom adjoint, differentiated directly") { |
| // forms a curry thunk of `Float.+` before conversion to @differentiable, and AD | ||
| // doesn't know how to differentiate the curry thunk, so it produces a | ||
| // "function is not differentiable" error. | ||
| // SupersetVJPTests.test("CrossModule") { |
There was a problem hiding this comment.
This one can be XFailed explicitly.
|
Thanks for catching those commented tests. They actually all pass now, so I have uncommented them. |
|
@swift-ci please test |
|
Build failed |
|
Build failed |
|
@swift-ci please test windows |
5 participants
These are copied straight from the
tensorflowbranch without any modifications necessary.