[Diagnostics] Refactor FailureDiagnostic to operate on TypedNode
#31104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eDiagnostic` This decouples `FailureDiagnostic` from expression.
In preparation to anchor `ConstraintLocator` from `TypedNode` let's refactor diagnostics (which is the biggest user of locators) to support `TypedNode` instead of `Expr *`.
Since `TypedNode` elements are all marked as `const` diagnostics need to get some of the APIs adjusted to support passing `const Expr *`.
Contributor
Author
|
@swift-ci please smoke test |
Contributor
Author
|
@swift-ci please smoke test Linux platform |
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch all of the relevant
FailureDiagnosticAPIs to useTypedNodeinstead ofExpr *and refactor diagnostic implementations to avoid relying on anchors being expressions where
possible.
Since
FailureDiagnosticis the biggest user ofConstraintLocatorthis refactoring enablesto transition locator from being anchored only on expressions.