Skip to content

Add compiler option to *disable* warnings-as-errors #31099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 20, 2020
Merged

Add compiler option to *disable* warnings-as-errors #31099

merged 1 commit into from
Apr 20, 2020

Conversation

@artemcm
Copy link
Contributor

@artemcm artemcm commented Apr 17, 2020

-no-warnings-as-errors

This functionality is required for build systems to be able to overload/disable a given Swift project's preference of treating warnings as errors.

Resolves rdar://problem/35699776

@artemcm
Copy link
Contributor Author

artemcm commented Apr 17, 2020

@swift-ci test

varungandhi-apple
varungandhi-apple reviewed Apr 17, 2020
View reviewed changes
@varungandhi-apple
Copy link
Contributor

varungandhi-apple commented Apr 17, 2020 •
edited
Loading

There's this piece of code which needs to be updated.

static void validateWarningControlArgs(DiagnosticEngine &diags,
                                       const ArgList &args) {
  if (args.hasArg(options::OPT_suppress_warnings) &&
      args.hasArg(options::OPT_warnings_as_errors)) {
    diags.diagnose(SourceLoc(), diag::error_conflicting_options,
                   "-warnings-as-errors", "-suppress-warnings");
  }
}

If there is a -no-warnings-as-errors afterwards, we shouldn't emit a error_conflicting_options.

DougGregor
DougGregor reviewed Apr 17, 2020
View reviewed changes
nkcsgexi
nkcsgexi reviewed Apr 17, 2020
View reviewed changes
@artemcm
Add compiler option to *disable* warnings-as-errors
c3b0232 
`-no-warnings-as-errors`

This functionality is required for build systems to be able to overload/disable a given Swift project's preference of treating warnings as errors.

Resolves rdar://problem/35699776
@artemcm artemcm force-pushed the NoWarningsAsErrorsOption branch from 598381e to c3b0232 Compare April 17, 2020 19:10
@varungandhi-apple
Copy link
Contributor

varungandhi-apple commented Apr 17, 2020

@swift-ci please test

@swift-ci
Copy link
Contributor

swift-ci commented Apr 17, 2020

Build failed
Swift Test Linux Platform
Git Sha - 598381e948970332c47748173b6fd9bcb0f00d52

@swift-ci
Copy link
Contributor

swift-ci commented Apr 17, 2020

Build failed
Swift Test OS X Platform
Git Sha - 598381e948970332c47748173b6fd9bcb0f00d52

@artemcm artemcm merged commit c11f013 into swiftlang:master Apr 20, 2020
@artemcm artemcm deleted the NoWarningsAsErrorsOption branch April 20, 2020 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DougGregor DougGregor DougGregor left review comments

@nkcsgexi nkcsgexi nkcsgexi approved these changes

+1 more reviewer

@varungandhi-apple varungandhi-apple varungandhi-apple approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@artemcm @varungandhi-apple @swift-ci @DougGregor @nkcsgexi