[CxxInterop] Add tests for extern vars #31093
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gribozavr
reviewed
Apr 17, 2020
gribozavr
reviewed
Apr 17, 2020
Co-Authored-By: Dmitri Gribenko <[email protected]>
gribozavr
reviewed
Apr 17, 2020
gribozavr
reviewed
Apr 17, 2020
gribozavr
reviewed
Apr 17, 2020
Contributor
|
Please also add SILGen and IRGen tests for passing the C globals as Swift |
gribozavr
reviewed
Apr 17, 2020
gribozavr
reviewed
Apr 17, 2020
Contributor
Author
Done. |
Contributor
|
@swift-ci Please smoke test |
Contributor
|
@swift-ci Please smoke test macOS |
1 similar comment
Contributor
|
@swift-ci Please smoke test macOS |
gribozavr
reviewed
Apr 20, 2020
gribozavr
reviewed
Apr 20, 2020
gribozavr
reviewed
Apr 20, 2020
gribozavr
approved these changes
Apr 20, 2020
Contributor
Author
|
PTAL :) |
gribozavr
approved these changes
Apr 20, 2020
Contributor
|
@swift-ci Please test |
Contributor
|
@swift-ci Please test Windows |
1 similar comment
Contributor
|
@swift-ci Please test Windows |
Contributor
|
@swift-ci Please smoke test macOS |
1 similar comment
Contributor
|
@swift-ci Please smoke test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now names of extern vars are not mangled therefore there are conflicts between toplevel vars and e.g. namespaced vars. These tests are commented out and accompanied with a FIXME. This will be fixed in #31070.
Progres on SR-12464.