Skip to content

Conversation

@slavapestov
Copy link
Contributor

@slavapestov slavapestov commented Apr 16, 2020

This is a regression between 5.2 and master. The first commit is the actual bug fix; the other three are small cleanups I noticed.

DeclContext::lookupQualified() no longer calls addImplicitContructors(),
so we have to do it ourselves here, otherwise we accept code that used
to be rejected in Swift 5.2.
@slavapestov slavapestov requested a review from CodaFi April 16, 2020 20:02
@slavapestov
Copy link
Contributor Author

@swift-ci Please smoke test

@slavapestov
Copy link
Contributor Author

@swift-ci Please test source compatibility

@slavapestov
Copy link
Contributor Author

@compnerd Looks like the builder is out of disk space:

C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.24.28314\include\xmemory(243): fatal error C1088: Cannot flush compiler intermediate file: 'C:\Users\ci\AppData\Local\Temp\_CL_3db5008bex': No space left on device

Copy link
Contributor

@CodaFi CodaFi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slavapestov slavapestov merged commit 51db014 into swiftlang:master Apr 16, 2020
@compnerd
Copy link
Member

@slavapestov fixed up - seems that another host had filled up the entire disk with the clang module cache

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants