[TypeChecker] <unknown> diagnostic location regarding Codable derived conformances

[HassanElDesouky]

Fixing diagnostic location regarding Codable derived conformances.

rdar://problem/59655704
Resolves SR-12248.

[HassanElDesouky]

@CodaFi Please review. And sorry for the inconvenience :)

[HassanElDesouky]

@CodaFi when this gets merged I'll open a PR for removing the setInvalids()s

[CodaFi]

Don't worry about it. We all miss tests all the time

@swift-ci smoke test

[CodaFi]

For reference, you can always rebase and force-push at your original PR instead of opening a new one if stuff like this arises.

Also making a note here that I'm going to squash this patch down manually once it passes. In the future, could you make sure to use

git pull --rebase <remote> <branch>

Instead of a normal git pull? That'll ensure there aren't any intervening merge commits which keeps the history somewhat more tidy.

[HassanElDesouky]

@CodaFi Thank you for the heads up! I really appreciate it.

It passed the tests now :)

[CodaFi]

⛵

[CodaFi]

Thanks. Don't forget to resolve the SR!

[HassanElDesouky]

Thanks. Don't forget to resolve the SR!

Of course! Thank you again 🙏