[DiagnosticVerifier] Fix ASAN issue in the verifier #30947
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci smoke test |
Contributor
Author
|
@swift-ci Please ASAN test |
omochi
approved these changes
Apr 10, 2020
Contributor
omochi
left a comment
omochi
left a comment
There was a problem hiding this comment.
Oh, I see.
I'll be careful in the future.
Contributor
Author
|
@omochi no problem, I didn't notice this either 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missed this when reviewing #30791 , but ASAN caught it here: https://ci.swift.org//job/oss-swift-incremental-ASAN-RA-osx/4602/consoleFull#-17223166953122a513-f36a-4c87-8ed7-cbc36a1ec144
This would manifest as a stack-use-after-scope because an
llvm::Twinecan't be safely stored.