[SILOptimizer] Disable SILCombiner::visitPartialApplyInst for method callees.
#30877
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test SR-12548: `SILCombiner::visitPartialApplyInst` rewrites `partial_apply` with `@convention(method)` callee to `thin_to_thick_function`. This produces a SIL verification error: `thin_to_thick_function` only supports `@convention(thin)` operands.
Contributor
Author
|
@atrick: could you please review, as a SILOptimizer code owner? |
Contributor
Author
|
@swift-ci Please test |
…d callees. Disable `SILCombiner::visitPartialApplyInst` from rewriting `partial_apply` with with `@convention(method)` callee to `thin_to_thick_function`. This fixes SIL verification errors: `thin_to_thick_function` only supports `@convention(thin)` operands. Resolves SR-12548.
Contributor
Author
|
@swift-ci Please test |
Contributor
|
Build failed |
Contributor
|
Build failed |
Contributor
Author
|
@swift-ci Please test macOS |
Contributor
Author
|
@jckarter commented that this change makes sense. Creating |
marcrasi
approved these changes
Apr 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable
SILCombiner::visitPartialApplyInstfrom rewritingpartial_applywithwith
@convention(method)callee tothin_to_thick_function.This fixes SIL verification errors:
thin_to_thick_functiononly supports@convention(thin)operands.Resolves SR-12548.
Unblocks #30875.
Context: the differentiation transform (
VJPEmitter::visitApply) generatespartial_applywith substitutions without arguments to polymorphic function references. With-O, some of these references are specialized, leading to the case above (partial_applyof@convention(method)callee without substitutions or arguments).