No longer pass llvm enable lto into swift cmake invocation #2979
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eLists.txt => cmake/modules/AddSwiftUnittests.cmake. rdar://24717107
…tion. *NOTE* We are still passing this variable into LLVM. Just not into Swift anymore. I originally passed in the variable -DLLVM_ENABLE_LTO=YES to Swift's cmake to ensure that the Swift unittests were compiled with lto. That was the wrong fix. The reason why is that if -DLLVM_ENABLE_LTO is set to YES then HandleLLVMOptions in llvm will append -flto to both CMAKE_C_FLAGS and CMAKE_CXX_FLAGS implying that -flto can not be disabled selectively. This ability to disable flto selectively is something that we need in order to lto host libraries, but not lto target libraries. Thus in this commit, we no longer pass in -DLLVM_ENABLE_LTO=YES to swift's cmake invocation. Instead we apply the lto flag to the unittest target ourselves in add_swift_unittest. rdar://24717107
Contributor
Author
|
@swift-ci Please smoke test and merge |
gottesmm
deleted the
no_longer_pass_llvm_enable_lto_into_swift_cmake_invocation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
Resolved bug number: (SR-)
Before merging this pull request to apple/swift repository:
Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
Validation Testing
Lint Testing
Note: Only members of the Apple organization can trigger swift-ci.