Skip to content

[gardening] PEP-8: First argument of a classmethod should be named 'cls'. Fix typo. #2968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 9, 2016
Merged

[gardening] PEP-8: First argument of a classmethod should be named 'cls'. Fix typo. #2968

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
856f0d6
[gardening] First argument of a classmethod should be named 'cls'
practicalswift Jun 9, 2016
285b6b5
[gardening] Fix typo.
practicalswift Jun 9, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions utils/swift_build_support/swift_build_support/targets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,8 +200,8 @@ def default_stdlib_deployment_targets():
return [host_target]

@classmethod
def get_target_for_name(klass, name):
return klass._targets_by_name.get(name)
def get_target_for_name(cls, name):
return cls._targets_by_name.get(name)


def install_prefix():
Expand Down
2 changes: 1 addition & 1 deletion utils/swift_build_support/tests/test_toolchain.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ def test_tools_llvm_suffix(self):

def test_toolchain_instances(self):
# Check that we can instantiate every toolchain, even if it isn't the
# current patform.
# current platform.
toolchain.MacOSX()
toolchain.Linux()
toolchain.FreeBSD()
Expand Down