[GSB] Map invalid subject types in requirement constraints to ErrorType #29491
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci test |
theblixguy
approved these changes
Jan 28, 2020
CodaFi
commented
Jan 28, 2020
Resolves SR-12072 and rdar://58941114
CodaFi
force-pushed
the
constraint-kinds
branch
from
7daac9a to
88d6559
Compare
Contributor
Author
|
@swift-ci please smoke test |
Contributor
Author
|
⛵️ |
slavapestov
reviewed
Jan 31, 2020
|
|
||
| class C {} | ||
| protocol Foo { | ||
| associatedtype X where C: X |
Contributor
There was a problem hiding this comment.
It would be better if we had a test for this in tests/ to check the diagnostic message makes sense
Contributor
There was a problem hiding this comment.
(I see it makes sense: qq.swift:3:28: error: type 'C' constrained to non-protocol, non-class type 'Self.X' but it would be good to ensure it doesn't regress and surface error types or something)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves SR-12072 and rdar://58941114