getInterfaceType() always returns a type #28210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We call isInvalid() a few lines above, so the interface type gets computed anyway.
|
@swift-ci please test |
CodaFi
reviewed
Nov 12, 2019
| } | ||
| assert(isa<CaseStmt>(initialCaseVarDecl->getParentPatternStmt())); | ||
|
|
||
| if (vd->getInterfaceType() && initialCaseVarDecl->getType() && |
There was a problem hiding this comment.
VarDecl::getType() also computes the interface type.
There was a problem hiding this comment.
Ah nice, even more cleanup
|
@swift-ci please test |
|
Build failed |
slavapestov
approved these changes
Nov 12, 2019
|
This picked up the libSyntax failures @swift-ci please test macOS platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove a handful of checks for whether
getInterfaceType()returns a non-null type, as it now always returns a non-null type. Also remove a couple of unnecessary calls tohasInterfaceType().