[Serialization] Teach serialization to get a generic signature from opaque types #26586
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Trying to make a test case for this now |
jckarter
approved these changes
Aug 9, 2019
Contributor
jckarter
left a comment
jckarter
left a comment
There was a problem hiding this comment.
Thanks for fixing this!
Contributor
Author
|
@swift-ci please smoke test |
1 similar comment
Contributor
Author
|
@swift-ci please smoke test |
added 2 commits
August 12, 2019 15:08
…YPE_PATH_PIECE We might have an opaque return type path piece after a generic type param type, so make sure to emit the XREF entry before the opaque return type path piece as well. Fixes rdar://53958358
…paque types Previously, if we had an XREF to an opaque type, we would fail trying to get the generic signature from that type. Fixes rdar://53958358
harlanhaskins
force-pushed
the
xref-vision
branch
from
adc4b1e to
114b039
Compare
Contributor
Author
|
@swift-ci please smoke test Linux |
Contributor
Author
|
@swift-ci please smoke test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if we had an XREF to an opaque type, we would fail trying to
get the generic signature from that type.
Fixes rdar://53958358