rdar://problem/26424505 Import as Member: QoI errors #2650
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…API notes don't crash.
We now reject this in Clang.
This is now diagnosed on the Clang side.
… notes. Most cases fall out from swift_name validation on the Clang side dropping invalid API notes, though the validation on the Clang side is conservative and misses some cases. We still have Swift-side work to fall back to the original name here.
Contributor
Author
|
@jrose-apple Do you mind reviewing these changes along with apple/swift-clang#15 ? |
Member
|
@swift-ci test |
Contributor
Author
|
Failure is expected until apple/swift-clang#15 merges. |
Member
|
apple/swift-clang#15 has been merged. |
Member
|
@swift-ci smoke test os x platform |
Member
|
@swift-ci test linux |
Member
|
If Linux CI comes back good I'll merge. |
| extern void IAMErrorStructHasPrototype(void) | ||
| __attribute__((swift_name("ErrorStruct.hasPrototype()"))); // ok | ||
| extern void IAMErrorStructNonPrototype() | ||
| __attribute__((swift_name("ErrorStruct.nonPrototype()"))); // error |
Contributor
There was a problem hiding this comment.
This is pretty much the entire thing being tested, and now the comment is wrong. If there's a test on the Clang side I'm okay with removing it.
Contributor
Author
There was a problem hiding this comment.
That was my thinking; now that we have better Clang-side validation and just throw the attr away if it's invalid, this wasn't really nonredundantly testing anything anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test updates necessary to keep up with the swift-clang changes in apple/swift-clang#15 . This depends on that pull request getting merged into Clang's 3.0 branch simultaneously.