-
Notifications
You must be signed in to change notification settings - Fork 10.6k
Basic: normalise android triples when loading modules #26486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@swift-ci please test |
|
Build failed |
|
Build failed |
4b8b547 to
3589915
Compare
|
@swift-ci please test |
|
Build failed |
|
Build failed |
|
Seems that the test should be limited to when the Android stdlib has been built. I don't know how that can be transformed into a lit requirement, thought. |
|
I mean, I could do |
The android API level can be ignored when loading the module. The API level controls the NDK APIs which are available and is equivalent to the SDK version for Darwin. This allows us to keep the API level in the triple which future versions of Android's toolchain does.
3589915 to
5de7c6f
Compare
|
@swift-ci please test |
|
Build failed |
|
Build failed |
The android API level can be ignored when loading the module. The API
level controls the NDK APIs which are available and is equivalent to the
SDK version for Darwin. This allows us to keep the API level in the
triple which future versions of Android's toolchain does.
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.