Skip to content

Conversation

@compnerd
Copy link
Member

@compnerd compnerd commented Aug 5, 2019

The android API level can be ignored when loading the module. The API
level controls the NDK APIs which are available and is equivalent to the
SDK version for Darwin. This allows us to keep the API level in the
triple which future versions of Android's toolchain does.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

@compnerd
Copy link
Member Author

compnerd commented Aug 5, 2019

@swift-ci please test

@swift-ci
Copy link
Contributor

swift-ci commented Aug 5, 2019

Build failed
Swift Test Linux Platform
Git Sha - 4b8b5473dfcbecd3ca952d57d4fb53669d4f6269

@swift-ci
Copy link
Contributor

swift-ci commented Aug 5, 2019

Build failed
Swift Test OS X Platform
Git Sha - 4b8b5473dfcbecd3ca952d57d4fb53669d4f6269

@compnerd compnerd force-pushed the android-API-level branch from 4b8b547 to 3589915 Compare August 5, 2019 03:42
@compnerd
Copy link
Member Author

compnerd commented Aug 5, 2019

@swift-ci please test

@swift-ci
Copy link
Contributor

swift-ci commented Aug 5, 2019

Build failed
Swift Test Linux Platform
Git Sha - 4b8b5473dfcbecd3ca952d57d4fb53669d4f6269

@swift-ci
Copy link
Contributor

swift-ci commented Aug 5, 2019

Build failed
Swift Test OS X Platform
Git Sha - 4b8b5473dfcbecd3ca952d57d4fb53669d4f6269

@drodriguez
Copy link
Contributor

Seems that the test should be limited to when the Android stdlib has been built. I don't know how that can be transformed into a lit requirement, thought.

@compnerd
Copy link
Member Author

compnerd commented Aug 6, 2019

I mean, I could do // REQUIRES: OS=android. But, I'm trying to be clever and create the Swift.swiftmodule manually just to make sure that we build and test with different triples. This seems to work locally, I wonder why it doesn't work here.

The android API level can be ignored when loading the module.  The API
level controls the NDK APIs which are available and is equivalent to the
SDK version for Darwin.  This allows us to keep the API level in the
triple which future versions of Android's toolchain does.
@compnerd compnerd force-pushed the android-API-level branch from 3589915 to 5de7c6f Compare August 6, 2019 03:14
@compnerd
Copy link
Member Author

compnerd commented Aug 6, 2019

@swift-ci please test

@swift-ci
Copy link
Contributor

swift-ci commented Aug 6, 2019

Build failed
Swift Test OS X Platform
Git Sha - 35899156c734ac3f8a46970ac35aa9e3bdf584ae

@swift-ci
Copy link
Contributor

swift-ci commented Aug 6, 2019

Build failed
Swift Test Linux Platform
Git Sha - 35899156c734ac3f8a46970ac35aa9e3bdf584ae

@compnerd compnerd merged commit 529d784 into swiftlang:master Aug 6, 2019
@compnerd compnerd deleted the android-API-level branch August 6, 2019 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants