[5.1] [Typechecker] Allow static functions to overload enum cases #25099
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e() to compute the type for the enum element decl, etc
Collaborator
Author
|
Can someone run the CI for me? @xedin @jrose-apple Thank you! |
Contributor
|
@swift-ci please test |
Collaborator
Author
|
Thank you @xedin! I think this is worth adding to the change log, so I’ll create another PR for it. |
Contributor
|
@slavapestov Since you looked a the original PR and I don't see anything about 5.1 there after quick look, do we want take this? |
Collaborator
Author
|
Ping. Can we merge this? |
Member
Member
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Totally forgot to cherry pick #23227 into this branch.
Fixes an issue with redeclaration checking where a static function would incorrectly get marked as a redeclaration of an enum element declaration, even if their types were different. See https://twitter.com/an0/status/1105187953834369025
Resolves SR-10084.