[android][tests] Pass Android include paths to sil-opt for testing. #23546
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Android NDK has the SDK for each architecture in one place, while the headers are in an unified sysroot. This makes the --sdk option insufficient for compiling GlibC. This commits adds the include paths so the test can succeed.
compnerd
approved these changes
Mar 26, 2019
Member
|
@swift-ci please smoke test and merge |
Contributor
Author
Member
|
@swift-ci please smoke test and merge |
Contributor
Author
|
I don’t understand the failure in Linux. Seems not related, and there is no recent changes in SwiftPM that might trigger it. 🤷♂️ |
Member
|
@swift-ci please smoke test Linux platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Android NDK has the SDK for each architecture in one place, while
the headers are in an unified sysroot. This makes the --sdk option
insufficient for compiling GlibC. This commits adds the include paths so
the test can succeed.
Fixes
SIL/verify_all_overlays.pyin Android.