[5.1 early] [ParseableInterface] Honor "exported module names" #23480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ParseableInterface] Honor "exported module names" (cherry picked from commit d8df1bf)
Contributor
Author
|
I don't think I can actually run PR tests on this branch, can I? But this change is very safe: most of it is moving existing things around without changing them, and then the last bit is changing parseable interface generation, which is still a new feature, to fix the problem, which is rare. |
Contributor
Author
|
@swift-ci Please test |
Contributor
|
Build failed |
Contributor
|
Build failed |
Contributor
Author
|
@shahmishal Looks like it doesn't work after all. That's probably okay, though. |
Member
|
@swift-ci test |
Contributor
|
Build failed |
Contributor
Author
|
The failing test was "SwiftSyntax :: print_verify_tree.swift", which would not be affected by this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #23474 to the early 5.1 branch for Apple purposes. Reviewed by @harlanhaskins.
rdar://problem/49114811