IRGen: simplify getSpareBitsForType #23442
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use an APInt to create the spare bit mask for integer values. This will allow us to byte swap it when we make the SpareBitVector strictly little-endian even when targeting big-endian machine. While editing this code I've also got rid of the goto statement since it seemed unnecessary.
mundaym
commented
Mar 20, 2019
|
|
||
| // Round Integer-Of-Unusual-Size types up to their allocation size. | ||
| unsigned allocBits = size.getValueInBits(); | ||
| assert(allocBits >= intTy->getBitWidth()); |
Contributor
Author
There was a problem hiding this comment.
I dropped this assertion since llvm::APInt::getBitsSetFrom already asserts this and the earlier DataLayout assertion will catch it first anyway probably.
jckarter
approved these changes
Mar 20, 2019
Contributor
jckarter
left a comment
jckarter
left a comment
There was a problem hiding this comment.
Thanks for cleaning this up!
Contributor
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My plan is to make non-functional changes similar to this PR everywhere in IRGen where I think we need to byte swap raw bit patterns on big-endian platforms. This will usually involve
SpareBitVectoruses being replaced with an appropriately sizedAPIntso that a byte swap can be done. Eventually we'd perhaps replaceSpareBitVectorwithAPInteverywhere as per @jckarter's comment in https://forums.swift.org/t/fixing-enums-on-big-endian-systems/21730/3 but I think it would be good to do that in stages.