Search for SwiftShims in SDK #23287
Merged
Search for SwiftShims in SDK #23287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…but only if the compiler resource directory doesn’t have them. These will move to the SDK soon.
|
My local testing of this is going very strangely in a way that doesn't look like it could be related to this change; I need to head home, so I'll see if it reproduces on CI. |
|
@swift-ci please clean smoke test |
jrose-apple
reviewed
Mar 14, 2019
|
@swift-ci smoke test |
|
Local testing looks good after a clean rebuild. |
jrose-apple
approved these changes
Mar 14, 2019
beccadax
added a commit
to beccadax/swift
that referenced
this pull request
Mar 15, 2019
…but only if the compiler resource directory doesn’t have them. These will move to the SDK soon.
beccadax
added a commit
that referenced
this pull request
Mar 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…but only if the compiler resource directory doesn’t have them. These will move to the SDK soon.
Resolves rdar://problem/48865477.