Mark lazy properties as having mutating getters immediately. #20796
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were trying to do this when synthesizing the getter prototype, but we don't do that immediately when we're just type-checking a reference to the storage, which could lead to the reference thinking that the getter was non-mutating. Fixes rdar://45712204.
Contributor
Author
|
@swift-ci Please test. |
slavapestov
approved these changes
Nov 27, 2018
AnnaZaks
approved these changes
Nov 27, 2018
Contributor
AnnaZaks
left a comment
AnnaZaks
left a comment
There was a problem hiding this comment.
Approve as it's a bug fix.
Contributor
|
@swift-ci Please test. |
1 similar comment
Contributor
|
@swift-ci Please test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were trying to do this when synthesizing the getter prototype, but we don't do that immediately when we're just type-checking a reference to the storage, which could lead to the reference thinking that the getter was non-mutating.
Fixes rdar://45712204.
This is the 5.0 branch version of #20779.
This is not ABI-affecting; it's just a bug-fix when type-checking multiple files. Probably not important for convergence because it's a crash-on-invalid.