stdlib: pass along alignment for dealloc #20686
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure that UnsafeMutablePointer.deallocate has the alignment that was used when invoking UnsafeMutablePointer.allocate. This is required to ensure that the appropriate `free` function is invoked. We would previously fail on Windows as the allocation would use `malloc` and due to the value being `-1`, use `_aligned_free` instead when deallocating.
Member
Author
|
@swift-ci please test |
Contributor
|
Build failed |
Member
Author
|
@swift-ci please test Linux platform |
Member
Author
|
CC: @mikeash |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that UnsafeMutablePointer.deallocate has the alignment that was
used when invoking UnsafeMutablePointer.allocate. This is required to
ensure that the appropriate
freefunction is invoked. We wouldpreviously fail on Windows as the allocation would use
mallocand dueto the value being
-1, use_aligned_freeinstead when deallocating.Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.