Fix-up toolchain script description. #20673
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xwu
reviewed
Nov 18, 2018
johnno1962
force-pushed
the
readme-toolchain
branch
from
667d906 to
abd5870
Compare
Collaborator
|
@swift-ci please smoke test |
shahmishal
approved these changes
Nov 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Apple,
Quick PR to fix some slight errors in the description of the build-toolchain script in the README.md.
As an aside I notice the main difference between the "-symbols” archive and the main toolchain archive is that the “-symbols” arrive does not contain an Info.plist! Can one be added? If this were fixed people could download and install the “-symbols” archive on it’s own rather than both.
Cheers.