Propagate concrete types for all arguments of an apply instruction #19287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@atrick @slavapestov the updated PR without use-after-scope problem. please review. |
atrick
approved these changes
Sep 13, 2018
Contributor
atrick
left a comment
atrick
left a comment
There was a problem hiding this comment.
Briefly re-reviewed. LGTM.
Contributor
Author
|
@atrick thanks. Who should review/smoke test etc. next? |
Contributor
|
@swift-ci test. |
Contributor
|
Sorry, I always forget you need me to run testing. I only use smoke test to retest after making a trivial change to the PR, like changing the commit message or comments. Otherwise, I do the full test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to merged and reverted PR #17370 that was reverted due to ASAN build problems as mentioned at https://ci.swift.org/job/oss-lldb-asan-osx/11/consoleFull#5770858633122a513-f36a-4c87-8ed7-cbc36a1ec144