Skip to content

Conversation

@jrose-apple
Copy link
Contributor

Otherwise, the textual interface won't see them, and any inlinable code that wants to make use of the protocol might get confused. We should have a check for this in the compiler itself, but for now I'm just providing this change to get unblocked.

(Okay, strictly speaking Encoding isn't a requirement right now, but it ought to be, right?)

Otherwise, the textual interface won't see them, and any inlinable
code that wants to make use of the protocol might get confused.
We should have a check for this in the compiler itself, but for now
I'm just providing this change to get unblocked.
@jrose-apple jrose-apple requested review from lancep and milseman August 21, 2018 01:19
@jrose-apple
Copy link
Contributor Author

@swift-ci Please smoke test

Copy link
Contributor

@lancep lancep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jrose-apple jrose-apple merged commit 9f7d6ce into swiftlang:master Aug 21, 2018
@jrose-apple jrose-apple deleted the let-me-introduce-you-to-my-associates branch August 21, 2018 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants