[CSSimplify] Fix matchCallArguments not to claim un-labeled argumen…
#18857
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci please smoke test |
harlanhaskins
approved these changes
Aug 20, 2018
Contributor
There was a problem hiding this comment.
Glad this one was improved!
Contributor
There was a problem hiding this comment.
This one is unfortunate, but livable...
Contributor
Author
There was a problem hiding this comment.
Right, because 2 is no longer re-ordered with a: 1, which I think is a more correct behavior.
Contributor
|
@xedin Can you update the commit message to make it clear whether the example you're giving is the old behavior or the new behavior? For example you could provide the example and an explanation of what happened before, versus after your change. |
Contributor
Author
|
@rudkx Sure! It’s currently an error, but I fixed it to type-check... |
…ts too eagerly Avoid claiming un-labeled defaulted parameters by out-of-order un-labeled arguments or parts of variadic argument sequence, because that might be incorrect. The following example is supposed to type-check correctly but without these changes produces `missing argument for parameter swiftlang#4 in call` error, because `3` will be claimed as '_ b:': ```swift func foo(_ a: Int, _ b: Int = 0, c: Int = 0, _ d: Int) {} foo(1, c: 2, 3) ``` Resolves: rdar://problem/43525641
Contributor
Author
|
@rudkx How does the message look like now? |
Contributor
Author
|
@swift-ci please smoke test |
Contributor
Author
|
@swift-ci please test source compatibility |
rudkx
approved these changes
Aug 21, 2018
Contributor
|
Thanks, @xedin! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ts too eagerly
Avoid claiming un-labeled defaulted parameters
by out-of-order un-labeled arguments or parts
of variadic argument sequence, because that might
be incorrect:
Resolves: rdar://problem/43525641