Reorganize code for findInitExistential #16950
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I don't see anything controversial about this. |
Contributor
|
Maybe create a new Existential.h? |
Contributor
Author
|
OK.
…On Fri, Jun 1, 2018 at 2:34 PM, Slava Pestov ***@***.***> wrote:
Maybe create a new Existential.h?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#16950 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AFBwaVwYMy6ecEQTZilL6xkgSFK6q_Lxks5t4bODgaJpZM4UXApj>
.
|
rajbarik
force-pushed
the
raj_reorg
branch
2 times, most recently
from
1379443 to
fdbdcdc
Compare
…ial.cpp/h in order for other passes such as ExistentialSpecializer to use it apart from SILCombiner
Contributor
Author
|
@slavapestov @atrick Please have a look. thanks. |
Contributor
|
LGTM |
Contributor
|
@swift-ci smoke test. |
Contributor
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently SILCombiner defines and uses findInitExistential and its associated functions as static and uses them. With the new ExistentialSpecializer pass (#13991), these utility functions are needed outside of SILCombiner. This PR only reorganizes the code (no new code added) and moves findInitExistentialFromGlobalAddr, getAddressOfStackInit, and findInitExistential functions to Local.h/cpp.